Conversation
…le button
- Replaces the visually hidden `<input type="checkbox" className="sr-only">` with a semantic `<button type="button" role="switch" aria-checked={localLock}>`.
- Ensures proper keyboard focus visibility (`focus-visible:ring-2 focus-visible:ring-cyan-400`).
- Fixes `LiveKeyboardA11y.test.tsx` which had an outdated assertion string.
Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What
Refactored the "LOCK TO SEQUENCER NOTES" custom switch in
SamplerVoicePanel.tsxto use a semantic<button role="switch">rather than a visually hidden<input type="checkbox">. Also updated a pre-existing broken test inLiveKeyboardA11y.test.tsx.🎯 Why
Visually hidden checkboxes (often implemented via
sr-onlyor opacity hacks) inside a<label>suppress native browser focus indicators. When a keyboard user tabs to the "LOCK TO SEQUENCER NOTES" switch, there was absolutely no visual indication that the element was focused, causing a severe WCAG accessibility failure.📸 Before/After
(Verified visually with Playwright)
Before: Tabbing to the lock switch showed no focus ring.
After: Tabbing to the lock switch renders a clear cyan focus ring around the toggle, allowing users to confidently navigate and toggle it via keyboard/Spacebar.
♿ Accessibility
role="switch"andaria-checked={localLock}.focus-visibleutilities.aria-hidden="true"to the adjacent text span so screen readers don't read the switch label twice.PR created automatically by Jules for task 18325537781248221405 started by @ford442